Re: [PATCH] PM-Timer: doesn't use workaround if chipset is not buggy

Andrew Morton <[email protected]> writes:

> OGAWA Hirofumi <[email protected]> wrote:
>>
>> +	dev = pci_get_device(PCI_VENDOR_ID_INTEL,
>> +			     PCI_DEVICE_ID_INTEL_82371AB_3, NULL);
>>
>> ...
>>
>> +device_initcall(pmtmr_bug_check);
>
> Can this code use the PCI quirk infrastructure?

Yes. However, since we need to check there is _not_ those chipsets,
it's tricky. Probably it's a following or similar code, um.. IMHO it
seems not simple enough. Idea?


static void __devinit blacklist_check()
{
	has_bug = 1;
}
DECLARE_PCI_FIXUP_EARLY(blacklist);

static void __devinit graylist_check()
{
	has_bug = 2;
}
DECLARE_PCI_FIXUP_EARLY(graylist);

static int __init pmtmr_bug_check()
{
	if (!has_bug)
		pmtmr_need_workaround = 0;
	else
        	...
}
late_initcall(pmtmr_bug_check);
-- 
OGAWA Hirofumi <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] PM-Timer: doesn't use workaround if chipset is not buggy
    • From: Andrew Morton <[email protected]>

• References:
  • gettimeofday order of magnitude slower with pmtimer, which is default
    • From: bert hubert <[email protected]>
  • Re: gettimeofday order of magnitude slower with pmtimer, which is default
    • From: john stultz <[email protected]>
  • Re: gettimeofday order of magnitude slower with pmtimer, which is default
    • From: OGAWA Hirofumi <[email protected]>
  • Re: gettimeofday order of magnitude slower with pmtimer, which is default
    • From: Con Kolivas <[email protected]>
  • [PATCH] PM-Timer: doesn't use workaround if chipset is not buggy
    • From: OGAWA Hirofumi <[email protected]>
  • Re: [PATCH] PM-Timer: doesn't use workaround if chipset is not buggy
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 1/2]Blackfin archtecture patche for 2.6.16
• Next by Date: Re: Lifetime of flash memory
• Previous by thread: Re: [PATCH] PM-Timer: doesn't use workaround if chipset is not buggy
• Next by thread: Re: [PATCH] PM-Timer: doesn't use workaround if chipset is not buggy
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]