Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3)

On Wed, 22 Mar 2006, Jesper Juhl wrote:

> Fix memory leak in mm/slab.c::alloc_kmemlist().
> If one allocation fails we have to roll-back all allocations made up to the 
> point of failure.

Sorry but you cannot roll back. alloc_kmemlist() could have been used for
tuning the cpucache while accesses to the slab continue. "Rolling back" 
would partially destroy the slab for some nodes and likely cause the 
system to crash. We can only roll back if this is actually an initial 
allocation and we are assured that the whole thing is not yet in use.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3)
  - From: Andrew Morton <[email protected]>

References:
- [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #2)
  - From: Jesper Juhl <[email protected]>
- Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #2)
  - From: "Pekka Enberg" <[email protected]>
- Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #2)
  - From: "Jesper Juhl" <[email protected]>
- Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3)
  - From: Jesper Juhl <[email protected]>

Prev by Date: RE: 2.6.16-rc5: known regressions [TP 600X S3, vanilla DSDT]
Next by Date: Re: Accessing kernel information from a module
Previous by thread: Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3)
Next by thread: Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3)
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]