On Wed, Mar 08, 2006 at 03:43:21PM -0800, Andrew Morton wrote: > Benjamin LaHaise <[email protected]> wrote: > > > > I think it may make more sense to simply convert local_t into a long, given > > that most of the users will be things like stats counters. > > > > Yes, I agree that making local_t signed would be better. It's consistent > with atomic_t, atomic64_t and atomic_long_t and it's a bit more flexible. > > Perhaps. A lot of applications would just be upcounters for statistics, > where unsigned is desired. But I think the consistency argument wins out. It already is... for most of the arches except x86_64. And on -mm, the asm-generic version uses atomic_long_t for local_t (signed long) which seems right. Although, I wonder why we use: #define local_read(l) ((unsigned long)atomic_long_read(&(l)->a)) It would return a huge value if the local counter was even -1 no? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [patch 0/4] net: percpufy frequently used vars on struct proto
- From: Ravikiran G Thirumalai <[email protected]>
- [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Andrew Morton <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Benjamin LaHaise <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Benjamin LaHaise <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Benjamin LaHaise <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Andrew Morton <[email protected]>
- [patch 0/4] net: percpufy frequently used vars on struct proto
- Prev by Date: RE: [PATCH] ftruncate on huge page couldn't extend hugetlb file
- Next by Date: RE: hugepage: Strict page reservation for hugepage inodes
- Previous by thread: Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- Next by thread: Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- Index(es):
 |