On Wed, Mar 08, 2006 at 12:26:56PM -0800, Ravikiran G Thirumalai wrote:
> +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long amount)
> +{
> + local_bh_disable();
> + fbc->count += amount;
> + local_bh_enable();
> +}
Please use local_t instead, then you don't have to do the local_bh_disable()
and enable() and the whole thing collapses down into 1 instruction on x86.
-ben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- References:
- [patch 0/4] net: percpufy frequently used vars on struct proto
- From: Ravikiran G Thirumalai <[email protected]>
- [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Andrew Morton <[email protected]>
- Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- From: Ravikiran G Thirumalai <[email protected]>
- [patch 0/4] net: percpufy frequently used vars on struct proto
- Prev by Date: Re: [Suspend2-announce] Nigel's work and the future of Suspend2.
- Next by Date: Re: [Suspend2-announce] Nigel's work and the future of Suspend2.
- Previous by thread: Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- Next by thread: Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
- Index(es):
 |