Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

[ebiederm@xmission.com (Eric W. Biederman)]

Paul Jackson <pj@sgi.com> writes:

>> Seems pointless.  This just increases #ifdef churn for no gain.
>
> Take a look at fs/proc/base.c.  That's how pretty much all the
> other proc hooks are done, with ifdef's around their proc hooks.
>
> ifdef minimization is a good goal, yes.
>
> But uniformity of practice is another good goal.

Agreed.  However the direction I am gradually moving fs/proc/base.c
is the opposite.  Moving things out of it as much as is reasonably
possible.

I already moved out all of the /proc/<pid>/?maps code into
fs/proc/task_mmu.c

I think the more important piece of uniform practice is to put all of
the operations structures and methods together in one file so that it
is easier to look between them, when making modifications especially
since cpuset_open and proc_cpuset_show are interdependent.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/