Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

Paul Jackson <[email protected]> writes:

>> Seems pointless.  This just increases #ifdef churn for no gain.
>
> Take a look at fs/proc/base.c.  That's how pretty much all the
> other proc hooks are done, with ifdef's around their proc hooks.
>
> ifdef minimization is a good goal, yes.
>
> But uniformity of practice is another good goal.

Agreed.  However the direction I am gradually moving fs/proc/base.c
is the opposite.  Moving things out of it as much as is reasonably
possible.

I already moved out all of the /proc/<pid>/?maps code into
fs/proc/task_mmu.c

I think the more important piece of uniform practice is to put all of
the operations structures and methods together in one file so that it
is easier to look between them, when making modifications especially
since cpuset_open and proc_cpuset_show are interdependent.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
    • From: Paul Jackson <[email protected]>

• References:
  • [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
    • From: Paul Jackson <[email protected]>
  • Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
    • From: Paul Jackson <[email protected]>

• Prev by Date: Re: 2.6.16rc5 'found' an extra CPU.
• Next by Date: Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
• Previous by thread: Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
• Next by thread: Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]