Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped

    Michael> Basically, its as Andrew said: the lock around clear_bit
    Michael> is there to ensure that ipoib_mcast_send isnt running
    Michael> already when we stop the thread.  Thats why test_bit has
    Michael> to be inside the lock, too.

Makes sense I guess.  If I'm understanding correctly, the lock isn't
really there to serialize the bit ops, but rather to make sure
ipoib_mcast_send() won't do anything after we clear the bit.

Does that mean that there's no reason to take the lock around the set_bit()?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
    • From: "Michael S. Tsirkin" <[email protected]>

• References:
  • [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
    • From: Roland Dreier <[email protected]>
  • Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
    • From: Andrew Morton <[email protected]>
  • Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
    • From: Roland Dreier <[email protected]>
  • Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
    • From: "Michael S. Tsirkin" <[email protected]>

• Prev by Date: Re: [PATCH] updated fstatat64 support
• Next by Date: [PATCH] reiserfs: disable automatic enabling of reiserfs inode attributes
• Previous by thread: Re: Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
• Next by thread: Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]