Roland Dreier <[email protected]> wrote:
>
> + spin_lock_irq(&priv->lock);
> + set_bit(IPOIB_MCAST_STARTED, &priv->flags);
> + spin_unlock_irq(&priv->lock);
Strange to put a lock around an atomic op like that.
Sometimes it's valid. If another cpu was doing:
spin_lock(lock);
if (test_bit(IPOIB_MCAST_STARTED))
something();
...
if (test_bit(IPOIB_MCAST_STARTED))
something_else();
spin_unlock(lock);
then the locked set_bit() makes sense.
But often it doesn't ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
