Quoting r. Kyle Moffett <[email protected]>: > On Feb 12, 2006, at 02:50, Michael S. Tsirkin wrote: > >Basically, its as Andrew said: the lock around clear_bit is there > >to ensure that ipoib_mcast_send isnt running already when we stop > >the thread. Thats why test_bit has to be inside the lock, too. > > Looks like you guys could use nonatomic versions to improve bus > efficiency slightly I think we need atomics since other places touch bits in the same word without taking the lock. -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- From: Roland Dreier <[email protected]>
- Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- From: Andrew Morton <[email protected]>
- Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- From: Roland Dreier <[email protected]>
- Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- From: "Michael S. Tsirkin" <[email protected]>
- Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- From: Kyle Moffett <[email protected]>
- [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- Prev by Date: Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- Next by Date: Re: Packet writing issue on 2.6.15.1
- Previous by thread: Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- Next by thread: Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
- Index(es):
 |