Re: [PATCH] stop ==== emergency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 5 Feb 2006, Pete Zaitcev wrote:
> On Fri, 3 Feb 2006 21:37:09 +0000 (GMT), Hugh Dickins <[email protected]> wrote:
> 
> > +++ linux/arch/i386/kernel/traps.c	2006-02-03 09:59:37.000000000 +0000
> > @@ -166,7 +166,8 @@ static void show_trace_log_lvl(struct ta
> >  		stack = (unsigned long*)context->previous_esp;
> >  		if (!stack)
> >  			break;
> > -		printk(KERN_EMERG " =======================\n");
> > +		printk(log_lvl);
> > +		printk(" =======================\n");
> >  	}
> 
> This is wrong, Hugh. What do you think the priority of the second printk?
> It's not log_lvl, that's for sure.

Are you sure?  I've not delved into the printk code itself, but this
does follow the same pattern as in show_stack_log_lvl itself e.g. its
"Call Trace:\n" line.  (I am assuming print_context_stack ends with a
newline, as it does.)

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux