Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super

Hello Jan,

mntput(path->mnt);   // too early mntput()
dput(path->dentry);

Assuming that in-between this sequence someone unmounts the file system, your patch will wait for this dput() to finish before it proceeds with unmounting

the file system. I think this isn't what we want.

No, it won't wait for anything, because if umount happened between mntput/dput, dentry is not in s_dshrinkers list. if umount happens in parallell with dput() (where shrinker operations are), then it will behave ok - will wait for dput() and then umount. It was intended behaviour!

It should not wait.

why?! it makes sure, that dentries/inodes are gone _before_ super block destroyed.

Also, please, note that such early mntput()'s are bugs!!! because such dentries can reference freed memory after last mntput(). And I remember some patches in 2.4.x/2.6.x which fixed this sequence everywhere.

Thats why I'm complaining ...

about what?
my patch doesn't hide this bug, nor helps it anyhow.

Kirill


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Olaf Hering <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>

• Prev by Date: Presentacion de trabajo / Job offer
• Next by Date: Re: [ANNOUNCE] Linux Kernel Useful Patches (2.4)
• Previous by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Next by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]