Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super

On Mon, Jan 23, Kirill Korotaev wrote:

> Jan, I still have not heard a single comment about what's wrong with 
> it... I would really appreciate if you provide me one.
> 

Sorry for the delay. I had to fix a totally bogus patch (mine ;).

The problem with your patch is that it hides too early mntput's. Think about
following situation:

 mntput(path->mnt);   // too early mntput()
 dput(path->dentry);

Assuming that in-between this sequence someone unmounts the file system, your
patch will wait for this dput() to finish before it proceeds with unmounting
the file system. I think this isn't what we want.

Regards,
	Jan

-- 
Jan Blunck                                               [email protected]
SuSE LINUX AG - A Novell company
Maxfeldstr. 5                                          +49-911-74053-608
D-90409 Nürnberg                                      http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>

• References:
  • [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Olaf Hering <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: Re: [ 00/23] [Suspend2] Freezer Upgrade Patches
• Next by Date: Re: Can on-demand loading of user-space executables be disabled ?
• Previous by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Next by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]