Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super

CPU 1				CPU 2
~~~~~				~~~~~
umount /dev/sda1
generic_shutdown_super          shrink_dcache_memory()
shrink_dcache_parent            dput dentry
select_parent                   prune_one_dentry()
                               <<<< child is dead, locks are released,
                                 but parent is still referenced!!! >>>>
skip dentry->parent,
since it's d_count > 0

message: BUSY inodes after umount...
                               <<< parent is left on dentry_unused list,
                                  referencing freed super block >>>

I see. The problem is that dcache_lock is given up before dereferencing the
parent. But your patch seems to be wrong anyway IMHO. I'll post patches in a
seperate thread.

Jan, I still have not heard a single comment about what's wrong with it... I would really appreciate if you provide me one.

Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>

• References:
  • [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Olaf Hering <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Jan Blunck <[email protected]>

• Prev by Date: Re: [PATCH] shrink_dcache_parent() races against shrink_dcache_memory()
• Next by Date: Re: [RFC] VM: I have a dream...
• Previous by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Next by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]