Re: [Linux-fbdev-devel] [PATCH] fbdev: Fix usage of blank value passed to fb_blank

[Ville Syrjälä <syrjala@sci.fi>]

On Sun, Jan 29, 2006 at 10:18:19AM +0800, Antonino A. Daplas wrote:
> diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
> index d2dede6..5bed0fb 100644
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -843,6 +843,19 @@ fb_blank(struct fb_info *info, int blank
>  {	
>   	int ret = -EINVAL;
>  
> +	/*
> +	 * The framebuffer core supports 5 blanking levels (FB_BLANK), whereas
> +	 * VESA defined only 4.  The extra level, FB_BLANK_NORMAL, is a
> +	 * console invention and is not related to power management.
> +	 * Unfortunately, fb_blank callers, especially X, pass VESA constants
> +	 * leading to undefined behavior.

Since when? X.Org uses numbers 0,2,3,4 which match the FB_BLANK 
constants not the VESA constants.

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/