Re: [PATCH] framebuffer: Remove old radeon driver

["Antonino A. Daplas" <adaplas@gmail.com>]

David S. Miller wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Sat, 28 Jan 2006 15:09:52 +1100
> 
>> On Sat, 2006-01-28 at 00:13 +0100, Michael Hanselmann wrote:
> 
> The radeon_screen_blank() routine returns error codes back
> to the X server which handily confuses it, making it
> impossible to unblank the screen unless X has taken it
> all the way to power-off or somesuch.  The comment above
> this problematic code states:
> 
> 	/* let fbcon do a soft blank for us */
> 	return (blank == FB_BLANK_NORMAL) ? -EINVAL : 0;
> 
> There has to be a better way to do this, which doesn't break
> X when run via fbcon. :-)
> 

The console layer has 5 blanking levels, with FB_BLANK_NORMAL defined
as "soft blank" (or blank the display without turning off display sync
signals) -- a console invention.  However, VESA has only 4 levels.

This can be easily fixed by incrementing the blank value by one if
the request originated from userspace.  I'll provide a patch
soon.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/