Re: [PATCH] framebuffer: Remove old radeon driver

On Saturday 28 January 2006 06:59, Antonino A. Daplas wrote:
> The console layer has 5 blanking levels, with FB_BLANK_NORMAL defined
> as "soft blank" (or blank the display without turning off display sync
> signals) -- a console invention.  However, VESA has only 4 levels.
> 
> This can be easily fixed by incrementing the blank value by one if
> the request originated from userspace.  I'll provide a patch
> soon.

May I suggest to hide this implementation detail?

E.g. please provide a macro/function blank_fb2vesa() just
for this detail instead of doing magic increments in those drivers.

Many thanks!


Regards

Ingo Oeser

Attachment: pgpyyIBLMlgsT.pgp
Description: PGP signature

---

• Follow-Ups:
  • [PATCH] fbdev: Fix usage of blank value passed to fb_blank
    • From: "Antonino A. Daplas" <[email protected]>

• References:
  • [PATCH] framebuffer: Remove old radeon driver
    • From: Michael Hanselmann <[email protected]>
  • Re: [PATCH] framebuffer: Remove old radeon driver
    • From: "David S. Miller" <[email protected]>
  • Re: [PATCH] framebuffer: Remove old radeon driver
    • From: "Antonino A. Daplas" <[email protected]>

• Prev by Date: Re: 2.6.16 - sys_sched_getaffinity & hotplug
• Next by Date: Re: 2.6.16 - sys_sched_getaffinity & hotplug
• Previous by thread: Re: [PATCH] framebuffer: Remove old radeon driver
• Next by thread: [PATCH] fbdev: Fix usage of blank value passed to fb_blank
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]