Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree

On Wed, 2006-01-18 at 16:52 -0800, [email protected] wrote:
> -                       memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> +                       memcpy(&current->saved_sigmask, &sigsaved,
> +                                       sizeof(sigsaved));

I still object to this.

You justified it on the basis that some people have editors which will
wrap the original version onto a second line and make it look ugly...
yet your 'fix' is to wrap it onto a second line and make it look ugly
for _all_ of us, not just for those using crap editors. I really don't
see the overall benefit.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree
    • From: Stephen Rothwell <[email protected]>

• Prev by Date: Re: RFC: ipath ioctls and their replacements
• Next by Date: Re: [robust-futex-4] futex: robust futex support
• Previous by thread: [PATCH] add ENTRY() declared label in .S files to tags
• Next by thread: Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]