Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 

Hi David,

On Thu, 19 Jan 2006 16:21:59 +1100 David Woodhouse <[email protected]> wrote:
>
> On Wed, 2006-01-18 at 16:52 -0800, [email protected] wrote:
> > -                       memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> > +                       memcpy(&current->saved_sigmask, &sigsaved,
> > +                                       sizeof(sigsaved));
> 
> I still object to this.
> 
> You justified it on the basis that some people have editors which will
> wrap the original version onto a second line and make it look ugly...
> yet your 'fix' is to wrap it onto a second line and make it look ugly
> for _all_ of us, not just for those using crap editors. I really don't
> see the overall benefit.

Documentation/CodingStyle says:

The limit on the length of lines is 80 columns and this is a hard limit.

Statements longer than 80 columns will be broken into sensible chunks.
Descendants are always substantially shorter than the parent and are placed
substantially to the right. The same applies to function headers with a long
argument list. Long strings are as well broken into shorter strings.

-- 
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/

Attachment: pgp95KgOcgTQh.pgp
Description: PGP signature

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux