Re: [PATCH 15/15] kconf: Check for eof from input stream.

[Ben Collins <ben.collins@ubuntu.com>]

On Thu, 2006-01-12 at 15:00 +0100, Roman Zippel wrote:
> > My point is that you are making oldconfig and silentoldconfig operate
> > differently when they encounter a closed stdin. You are making them
> > inconsistent. And so far, you have yet to give a valid reason to do so.
> > I've been giving very valid reasons why they should work the same, and
> > why the behavior is correct for them to work that way.
> 
> Even if they sound similiar they are not the same. e.g. I'm working on 
> patches to integrate split config step, so it will do a bit more than 
> normal config targets (but it remain a valid make target). The 
> silentoldconfig target is an automatic target which is also used by kbuild 
> to verify the config consistency.
> The situation is very simple, we have automatic config targets (like 
> silentoldconfig or all*config) and we have interactive config targets 
> (like config, xconfig, oldconfig).
> I'm very much interested to improve the situation of the automatic 
> targets to help automatic builds, but just printing useless information 
> adds no value. If you don't trust that silentoldconfig does the right 
> thing, you can't trust oldconfig either.

What I don't understand is that if oldconfig is an interactive target,
why make it work when interactivity is not available? Also, if
silentoldconfig is an automated target, why make it abort when
interactivity is not available?

Just seems backwards.

For me, silentoldconfig could work, but I prefer the verbosity of
oldconfig. It's just more convenient. It's not that things are checked
in minute detail, but that our builds may eventually disappear (by
upgraded packages), but our build logs remain. It's the only way we have
to go back and check regressions in the build process (it has saved us
many times).

-- 
   Ben Collins <ben.collins@ubuntu.com>
   Developer
   Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/