Re: [PATCH 15/15] kconf: Check for eof from input stream.

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Thu, 12 Jan 2006, Ben Collins wrote:

> > silentoldconfig gives you exactly the same information. Both conf and 
> > oldconfig will change invisible options without telling you, so it's not 
> > exact at all.
> > If you can't trust a silent oldconfig, a more verbose oldconfig can't tell 
> > you anything else, if it would it's a bug.
> 
> silentoldconfig tells you a lot less, agreed?

No.

> Hijack? It was broken, correct? It has always been broken. This problem
> has existed for as long as I've been handling kernel builds with Debian
> (which seems to be about 6-7 years now). So intended behavior aside, it
> has never worked as intended.

And it took you 6 years to report this problem?

> > > 5) My patch did not break anything, nor did it change anything that was
> > > already working.
> > 
> > It _was_ working like that, you're breaking it.
> 
> At what point did oldconfig use default values when stdin was closed?

It broke with this patch:

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commit;h=4b518e42f97b96abd84f5106e43711dbff3c5707

> > So simply use silentoldconfig.
> 
> That's not the usage I want.

You only want some specific output, which has zero advantage over the 
silentoldconfig output.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/