Re: [PATCH 15/15] kconf: Check for eof from input stream.

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Thu, 12 Jan 2006, Ben Collins wrote:

> > > silentoldconfig tells you a lot less, agreed?
> > 
> > No.
> 
> So you are saying that silentoldconfig outputs no less information than
> oldconfig? No output compared to a full config output (yes, with some
> special cased invisible options, but the same output that a user would
> see if manually configuring).

You're seriously telling me that you check every line of the oldconfig 
output in case of the problem? 
If it makes you feel better, you can rerun oldconfig after the 
silentoldconfig, but the output is practically useless.
It would actually be a lot better if you ran a diff between the old config 
and the new config and add this to the build output, only the contents of 
the .config file is relevant to kbuild and if something went wrong, the 
real differences would be easily visible.

> My point is that you are making oldconfig and silentoldconfig operate
> differently when they encounter a closed stdin. You are making them
> inconsistent. And so far, you have yet to give a valid reason to do so.
> I've been giving very valid reasons why they should work the same, and
> why the behavior is correct for them to work that way.

Even if they sound similiar they are not the same. e.g. I'm working on 
patches to integrate split config step, so it will do a bit more than 
normal config targets (but it remain a valid make target). The 
silentoldconfig target is an automatic target which is also used by kbuild 
to verify the config consistency.
The situation is very simple, we have automatic config targets (like 
silentoldconfig or all*config) and we have interactive config targets 
(like config, xconfig, oldconfig).
I'm very much interested to improve the situation of the automatic 
targets to help automatic builds, but just printing useless information 
adds no value. If you don't trust that silentoldconfig does the right 
thing, you can't trust oldconfig either.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/