Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

On Thu, 2005-12-15 at 11:21 -0800, Andrew Morton wrote:
> Linus Torvalds <[email protected]> wrote:
> >
> > On Thu, 15 Dec 2005, David Howells wrote:
> >  > 
> >  > 	FROM				TO
> >  > 	==============================	=========================
> >  > 	DECLARE_MUTEX			DECLARE_SEM_MUTEX
> >  > 	DECLARE_MUTEX_LOCKED		DECLARE_SEM_MUTEX_LOCKED
> >  > 	Proper counting semaphore	DECLARE_SEM
> > 
> >  That sounds fine.
> 
> They should be renamed to DEFINE_* while we're there.  A "declaration" is
> "this thing is defined somewhere else".  A "definition" is "this thing is
> defined here".

Why have the "MUTEX" part in there?  Shouldn't that just be DECLARE_SEM
(oops, I mean DEFINE_SEM).  Especially that MUTEX_LOCKED! What is that?
How does a MUTEX start off as locked.  It can't, since a mutex must
always have an owner (which, by the way, helped us in the -rt patch to
find our "compat_semaphores").  So who's the owner of a
DEFINE_SEM_MUTEX_LOCKED?

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Geert Uytterhoeven <[email protected]>

• References:
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Paul Jackson <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Alan Cox <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Paul Jackson <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Paul Jackson <[email protected]>
  • [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Mark Lord <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Nikita Danilov <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Alan Cox <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andrew Morton <[email protected]>

• Prev by Date: agpgart.ko can't be unloaded
• Next by Date: Re: Linux 2.6.13.5
• Previous by thread: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
• Next by thread: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]