On Mer, 2005-12-07 at 20:15 +0100, Bartlomiej Zolnierkiewicz wrote: > PS1 Please don't use taskfile_lib_get_identify(), drive->id > should contain valid ID - if it doesn't it is a BUG. If someone swapped the drive while suspended that isnt true. OTOH I'm not sure what the hell you'd do if that was the case and you are using drivers/ide right now. > PS2 Have you seen libata ACPI patches by Randy? > Maybe some of the code dealing with ACPI can be put to > <linux/ata.h> and be shared between IDE and libata drivers? Definitely a good idea. Also exposing the methods will be useful for producing a proper libata 'ata_acpi' driver that does the best it can using ACPI methods for tuning unknown hardware. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Pavel Machek <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Bartlomiej Zolnierkiewicz <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- References:
- [RFC]add ACPI hooks for IDE suspend/resume
- From: Shaohua Li <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Matthew Garrett <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Bartlomiej Zolnierkiewicz <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Matthew Garrett <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Bartlomiej Zolnierkiewicz <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Matthew Garrett <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Bartlomiej Zolnierkiewicz <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Alan Cox <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Bartlomiej Zolnierkiewicz <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Shaohua Li <[email protected]>
- Re: [RFC]add ACPI hooks for IDE suspend/resume
- From: Bartlomiej Zolnierkiewicz <[email protected]>
- [RFC]add ACPI hooks for IDE suspend/resume
- Prev by Date: Re: [ckrm-tech] [RFC][Patch 3/5] Per-task delay accounting: Sync block I/O delays
- Next by Date: Re: 2.6.15-rc4 Oops in show_smaps()
- Previous by thread: Re: [RFC]add ACPI hooks for IDE suspend/resume
- Next by thread: Re: [RFC]add ACPI hooks for IDE suspend/resume
- Index(es):