Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static

Dave Jones <[email protected]> wrote:
>
> On Wed, Nov 23, 2005 at 11:54:40PM +0100, Adrian Bunk wrote:
>  > On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote:
>  > > On Wed, 23 Nov 2005, Adrian Bunk wrote:
>  > > 
>  > > > Every inline dummy function should be static.
>  > > 
>  > > Please explain why it matters in this case.
>  > 
>  > We don't need an additional global copy of the function.
> 
> it's an empty body, surely the compiler will compile it away ?
> 

With

inline void foo(void)
{
}

The compiler has to put an out-of-line copy of foo() into this .o file in
case some other .o file calls it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- 2.6.15-rc2-mm1
  - From: Andrew Morton <[email protected]>
- [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
  - From: Adrian Bunk <[email protected]>
- Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
  - From: "Randy.Dunlap" <[email protected]>
- Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
  - From: Adrian Bunk <[email protected]>
- Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
  - From: Dave Jones <[email protected]>

Prev by Date: Re: 2.6.15-rc2-mm1
Next by Date: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
Previous by thread: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
Next by thread: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]