Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static

On Wed, 23 Nov 2005, Adrian Bunk wrote:

> Every inline dummy function should be static.

Please explain why it matters in this case.

> Signed-off-by: Adrian Bunk <[email protected]>
>
> --- linux-2.6.15-rc2-mm1-full/init/main.c.old	2005-11-23 16:50:45.000000000 +0100
> +++ linux-2.6.15-rc2-mm1-full/init/main.c	2005-11-23 16:50:55.000000000 +0100
> @@ -101,7 +101,7 @@
>  static inline void acpi_early_init(void) { }
>  #endif
>  #ifndef CONFIG_DEBUG_RODATA
> -inline void mark_rodata_ro(void) { }
> +static inline void mark_rodata_ro(void) { }
>  #endif
>
>  #ifdef CONFIG_TC

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
  - From: Adrian Bunk <[email protected]>

References:
- 2.6.15-rc2-mm1
  - From: Andrew Morton <[email protected]>
- [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
  - From: Adrian Bunk <[email protected]>

Prev by Date: Re: [RFC] [PATCH 2/3] ioat: user buffer pin; net DMA client register
Next by Date: Re: rfc/rft: use r10 as current on x86-64
Previous by thread: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
Next by thread: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]