Re: [PATCH 2/4] swsusp: clean up resume error path

Hi!

> > I don't like this one. restore_highmem() does freeing of allocated
> > pages. If swsusp_arch_suspend() fails in specific way, I suspect it
> > could leak highmem.
> 
> The pages to be freed are only allocated in suspend_prepare_image()
> (now swsusp_save()), which is on suspend, and this is the resume
> error path.

Ok, yes, you seem to be right. I was probably confused by my own
code. ACK on the patch (if it helps you).

								Pavel

-- 
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/4] swsusp: more cleanups
    • From: "Rafael J. Wysocki" <[email protected]>
  • [PATCH 2/4] swsusp: clean up resume error path
    • From: "Rafael J. Wysocki" <[email protected]>
  • Re: [PATCH 2/4] swsusp: clean up resume error path
    • From: Pavel Machek <[email protected]>
  • Re: [PATCH 2/4] swsusp: clean up resume error path
    • From: "Rafael J. Wysocki" <[email protected]>

• Prev by Date: Re: PATCH: Bluesmoke missing renames
• Next by Date: Re: [Fastboot] [PATCH] i386: move apic init in init_IRQs
• Previous by thread: Re: [PATCH 2/4] swsusp: clean up resume error path
• Next by thread: [PATCH 1/4] swsusp: get rid of unnecessary wrapper function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]