Hi!
> The following patch removes an incorrect call to restore_highmem() from
> the resume error path (there's no saved highmem in that case) and makes
> swsusp touch the softlockup watchdog if there's no error (currently it only
> touches the watchdog if an error occurs).
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
>
> Index: linux-2.6.14-rc4-mm1/kernel/power/swsusp.c
> ===================================================================
> --- linux-2.6.14-rc4-mm1.orig/kernel/power/swsusp.c 2005-10-17 23:28:34.000000000 +0200
> +++ linux-2.6.14-rc4-mm1/kernel/power/swsusp.c 2005-10-17 23:28:47.000000000 +0200
> @@ -628,7 +629,6 @@
> */
> swsusp_free();
> restore_processor_state();
> - restore_highmem();
> touch_softlockup_watchdog();
> device_power_up();
> local_irq_enable();
I don't like this one. restore_highmem() does freeing of allocated
pages. If swsusp_arch_suspend() fails in specific way, I suspect it
could leak highmem.
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
