Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]

* David Howells ([email protected]) wrote:
> Chris Wright <[email protected]> wrote:
> 
> > > +{
> > > +	return -1;
> > > +}
> > 
> > No solid reason on that one, might as well be 0 for consistency.
> 
> Grrr! That needs to be zero otherwise it'll deny everything by default. I'd
> fallen over that one and fixed it, but I must've forgotten to rediff the patch
> before submitting it.

I thought that too at first, which is why I flagged it at first.  But I
think it's actually not a real problem, because isn't that !CONFIG_KEYS?
So, I think it's just cosmetic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
    • From: Chris Wright <[email protected]>
  • [PATCH] Keys: Possessor permissions should be additive
    • From: David Howells <[email protected]>
  • [PATCH] Keys: Split key permissions checking into a .c file
    • From: David Howells <[email protected]>
  • [PATCH] Keys: Add LSM hooks for key management [try #2]
    • From: David Howells <[email protected]>
  • Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
    • From: David Howells <[email protected]>

• Prev by Date: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
• Next by Date: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
• Previous by thread: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
• Next by thread: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]