On Thu, Oct 06, 2005 at 12:42:25PM +0200, Andi Kleen wrote:
> On Thursday 06 October 2005 01:17, Siddha, Suresh B wrote:
>
> > +
> > +#ifdef CONFIG_X86_HT
> > +#ifndef CONFIG_X86_64
> > +#include <mach_apic.h>
> > +#else
> > +#include <asm/mach_apic.h>
> > +#endif
>
> Having such ifdefs is a clear cue that the code shouldn't be shared
> between architectures.
Andi, Those headers are for phys_pkg_id(). And its meaning is same on both
x86 and x86_64(though its API is different. We can make it consistent across
x86 and x86_64. But that will not solve the above pointed out ifdef hunk)
Unfortunately x86 mach specific vector implementation is not as simple as
x86_64, resulting in the above ifdefs mess...
I can fix the API mess. Is there anything else you want me to do?
thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
