On Wed Oct 05, 2005 at 12:19:43AM +0200, Jesper Juhl wrote:
> On Tuesday 04 October 2005 08:21, Jens Axboe wrote:
> [snip]
> > This is a mess. So NACK on this patch. And why are you changing the
> [snip]
>
> Hi Jens,
>
> Sorry about the messy previous patch. Would you consider something like the
> one below instead? It only makes a few changes, not lots of different ones in
> the same patch and it also only makes changes that I hope you'll agree are
> useful. :)
>
>
> Remove some unneeded casts.
> Avoid an assignment in the case of kmalloc failure.
> Break a few instances of if (foo) whatever; into two lines.
Revised patch looks ok to me. I stopped maintaining this
code years ago, but since I was CC'd...
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
