Re: [PATCH] ide-cd cleanup (casts, whitespace and codingstyle)

[Jesper Juhl <jesper.juhl@gmail.com>]

On 10/4/05, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Tue, Oct 04, 2005 at 12:17:56AM +0200, Jesper Juhl wrote:
> > --- linux-2.6.14-rc3-git3-orig/drivers/ide/ide-cd.c
> > +++ linux-2.6.14-rc3-git3/drivers/ide/ide-cd.c
>
> What was wrong with these ones? [snipping the rest]
>

Nothing much, simply that as far as I know, the common coding style is
that function declarations/definitions should be on one line and if
that line can't fit in 80 chars then arguments are moved to the next
line and indented by two tabs. That's the style I believe is the most
official one (if such a thing exists), so that's the style I changed
everything throughout the file to obey.


> >  static int cdrom_log_sense(ide_drive_t *drive, struct request *rq,
> > -                        struct request_sense *sense)
> > +             struct request_sense *sense)
>
> > -static
> > -void cdrom_analyze_sense_data(ide_drive_t *drive,
> > -                           struct request *failed_command,
> > -                           struct request_sense *sense)
> > +static void cdrom_analyze_sense_data(ide_drive_t *drive,
> > +             struct request *failed_command, struct request_sense *sense)
>
> >  static void cdrom_queue_request_sense(ide_drive_t *drive, void *sense,
> > -                                   struct request *failed_command)
> > +             struct request *failed_command)
>
> >  static ide_startstop_t cdrom_start_packet_command(ide_drive_t *drive,
> > -                                               int xferlen,
> > -                                               ide_handler_t *handler)
> > +             int xferlen, ide_handler_t *handler)
>
>


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/