Re: [PATCH] fix exit_itimers() vs posix_timer_event() AB-BA deadlock

Oleg Nesterov <[email protected]> wrote:
>
> +	/*
>  +	 * We are locking ->it_lock + tasklist_lock backwards
>  +	 * from release_task()->exit_itimers(), beware deadlock.
>  +	 */
>  +	leader = timr->it_process->group_leader;
>  +	while (unlikely(!read_trylock(&tasklist_lock))) {
>  +		if (leader->flags & PF_EXITING) {
>  +			smp_rmb();
>  +			if (thread_group_empty(leader))
>  +				return 0;
>  +		}
>  +		cpu_relax();
>  +	}

Oh dear.  Is there no way to fix this up by taking the locks in the correct
order?  (Whatever that is).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix exit_itimers() vs posix_timer_event() AB-BAdeadlock
    • From: Oleg Nesterov <[email protected]>

• References:
  • 2.6.13-rc6-rt9
    • From: Ingo Molnar <[email protected]>
  • [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment
    • From: Thomas Gleixner <[email protected]>
  • [PATCH] fix send_sigqueue() vs thread exit race
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] fix send_sigqueue() vs thread exit race
    • From: Oleg Nesterov <[email protected]>
  • [PATCH] fix exit_itimers() vs posix_timer_event() AB-BA deadlock
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: patching kgdb to linux
• Next by Date: Re: Suspend to RAM broken with 2.6.13
• Previous by thread: [PATCH] fix exit_itimers() vs posix_timer_event() AB-BA deadlock
• Next by thread: Re: [PATCH] fix exit_itimers() vs posix_timer_event() AB-BAdeadlock
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]