Re: [patch] x86_64: fix tss limit (was Re: CAN-2005-0204 and 2.4)

[Jesper Juhl <jesper.juhl@gmail.com>]

On 9/24/05, Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> On Sat, Sep 24, 2005 at 12:55:41AM +0200, Jesper Juhl wrote:
> > On 9/24/05, Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> > >         set_tssldt_descriptor(&cpu_gdt_table[cpu][GDT_ENTRY_TSS], (unsigned long)addr,
> > >                               DESC_TSS,
> > > -                             sizeof(struct tss_struct) - 1);
> > > +                             IO_BITMAP_OFFSET + IO_BITMAP_BYTES + 7);
> > >  }
> > >
> > [snip]
> >
> > Is it just me, or would it be nice with a symbolic name for this "7" ?
> > For someone reading the code for the first time it seems to me that
> > it's non-obvious why the 7 is there, and why it's 7 exactely - a
> > define would make it clearer as I see it.
>
> Andrew please apply this updated patch. Thanks.
>
[snip]

That change makes me happy :)

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/