Re: [patch] x86_64: fix tss limit (was Re: CAN-2005-0204 and 2.4)

[Jesper Juhl <jesper.juhl@gmail.com>]

On 9/24/05, Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
[snip]
>
> Fix the x86_64 TSS limit in TSS descriptor.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
>
> --- linux-2.6.14-rc1/include/asm-x86_64/desc.h.orig     2005-09-12 20:12:09.000000000 -0700
> +++ linux-2.6.14-rc1/include/asm-x86_64/desc.h  2005-09-23 12:50:58.210135128 -0700
> @@ -129,7 +129,7 @@ static inline void set_tss_desc(unsigned
>  {
>         set_tssldt_descriptor(&cpu_gdt_table[cpu][GDT_ENTRY_TSS], (unsigned long)addr,
>                               DESC_TSS,
> -                             sizeof(struct tss_struct) - 1);
> +                             IO_BITMAP_OFFSET + IO_BITMAP_BYTES + 7);
>  }
>
[snip]

Is it just me, or would it be nice with a symbolic name for this "7" ?
For someone reading the code for the first time it seems to me that
it's non-obvious why the 7 is there, and why it's 7 exactely - a
define would make it clearer as I see it.


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/