Re: [patch] hdaps driver update.

[Robert Love <rml@novell.com>]

On Wed, 2005-09-14 at 09:05 -0700, Greg KH wrote:

> Woah, no, this is not ok.  Please see my objections to this the zillion
> other times people have tried to do this...
> 
> Why is this static?  Shouldn't it be dynamic and then your release would
> be able to free the memory?

The release only happens on module unload, the device is not
hotpluggable, and thus we'd gain the memory anyhow.

So it is static the way any other no-need-to-dynamically-create data
structure would be.

No?

> >  static struct device_driver hdaps_driver = {
> >  	.name = "hdaps",
> >  	.bus = &platform_bus_type,
> > -	.owner = THIS_MODULE,
> >  	.probe = hdaps_probe,
> >  	.resume = hdaps_resume
> >  };
> 
> Why delete that?  You just lost your symlink in sysfs then :(

I don't follow.

Wouldn't we want to be removed from sysfs?

	Robert Love


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/