Re: [patch] hdaps driver update.

[Greg KH <greg@kroah.com>]

On Wed, Sep 14, 2005 at 11:57:33AM -0400, Robert Love wrote:
> +/* dummy release function -- everything is static, nothing to free */
> +static void hdaps_dummy_release(struct device *dev) { }

Woah, no, this is not ok.  Please see my objections to this the zillion
other times people have tried to do this...

Why is this static?  Shouldn't it be dynamic and then your release would
be able to free the memory?

>  static struct device_driver hdaps_driver = {
>  	.name = "hdaps",
>  	.bus = &platform_bus_type,
> -	.owner = THIS_MODULE,
>  	.probe = hdaps_probe,
>  	.resume = hdaps_resume
>  };

Why delete that?  You just lost your symlink in sysfs then :(

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/