On Fri, Aug 26, 2005 at 03:29:15PM -0400, Robert Love wrote:
> On Fri, 2005-08-26 at 20:55 +0100, Alan Cox wrote:
>
> > I think that should be fixed before its merged.
>
> Let me be clear, it has an init routine that effectively probes for the
> device.
>
> It just lacks a simple quick non-invasive check.
>
> The driver will definitely fail to load on a laptop without the
> requisite hardware.
Poking IO ports on hardware where you don't have the device
can be fatal. What happens if I have something completely different
at io port 0x1600 ? (Thus satisfying your request_region() check).
accelerometer_init() then happily starts poking ports, and performing
all kinds of voodoo.
Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |