Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.

• To: Andi Kleen <[email protected]>
• Subject: Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
• From: Nick Piggin <[email protected]>
• Date: Thu, 18 Aug 2005 12:52:24 +1000
• Cc: Eric Dumazet <[email protected]>, Benjamin LaHaise <[email protected]>, "David S. Miller" <[email protected]>, [email protected], [email protected]
• Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=fjYNROJtSaM1kriSmatpuYPiX341/G3HG/GPCtj9nBD1v83CKrui3wbd5fevIXxO2G7iHp2Y7pVc2Ox4GDneT79EE9Po74GQtstb3GJVWULIgsAfh3ZwmBfS8DsoVXZSfGcHHhw5RWR9T29Bf0be1vruiWd7lB9749qobTviuWk= ;
• In-reply-to: <[email protected]>
• References: <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Debian/1.7.8-1

Andi Kleen wrote:

I would just set the ra pointer to a single global structure if the allocation
fails. Then you can avoid all the other checks. It will slow down

things and trash some state, but not fail and nobody should expect good performance after out of memory anyways. The only check still

needed would be on freeing.

You don't want to always have bad performance though, so you
could attempt to allocate if either the pointer is null _or_ it
points to the global structure?

Send instant messages to your online friends http://au.messenger.yahoo.com -

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
    • From: Eric Dumazet <[email protected]>
  • Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH/RFT 4/5] CLOCK-Pro page replacement
• Next by Date: [PATCH] DVB: lgdt330x check callback fix
• Previous by thread: Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
• Next by thread: Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]