Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.

On Thu, Aug 18, 2005 at 02:40:46AM +0200, Eric Dumazet wrote:
> Andi Kleen a ?crit :
> 
> >
> >>(because of the insane struct file_ra_state f_ra. I wish this structure 
> >>were dynamically allocated only for files that really use it)
> >
> >
> >How about you submit a patch for that instead? 
> >
> >-Andi
> 
> OK, could you please comment this patch ?

I would just set the ra pointer to a single global structure if the allocation
fails. Then you can avoid all the other checks. It will slow down
things and trash some state, but not fail and nobody should expect good 
performance after out of memory anyways. The only check still
needed would be on freeing.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
  - From: Nick Piggin <[email protected]>
- Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
  - From: "David S. Miller" <[email protected]>

References:
- [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
  - From: Eric Dumazet <[email protected]>

Prev by Date: [PATCH 2.6.13-rc6 2/2] New Syscall: set rlimits of any process (update)
Next by Date: Re: sched_yield() makes OpenLDAP slow
Previous by thread: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
Next by thread: Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind]