Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 04, 2005 at 07:11:38PM +0200, Rolf Eike Beer wrote:
 > >It's pointless to fix this, without fixing also CpqTsGetSFQEntry()
 > At least half of the file should be rewritten.

Just half ? You're such an optimist :-)

 > > > No, ulDestPtr ist ULONG* so we increase it by sizeof(ULONG)*16 which is
 > > > 64.
 > >Duh, yes.  That is broken on 64-bit however, where it will advance 128 bytes
 > >instead of 64 bytes.
 > 
 > ULONG is defined to __u32 in some of the cpq* headers.

Ewwwww.
Ok, definitly time to stop reading.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux