Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

[Jesper Juhl <jesper.juhl@gmail.com>]

On 8/4/05, Saripalli, Venkata Ramanamurthy (STSD) <saripalli@hp.com> wrote:
> Patch 1 of 2
> 
> This patch fixes the "#error this is too much stack" in 2.6 kernel.
> Using kmalloc to allocate memory to ulFibreFrame.
> 
[snip]
>            if( fchs->pl[0] == ELS_LILP_FRAME)
>           {
> +           kfree(ulFibreFrame);
>              return 1; // found the LILP frame!
>           }
>           else
>           {
> +           kfree(ulFibreFrame);
>             // keep looking...
>           }

The first thing you do in either branch is to call
kfree(ulFibreFrame); , so instead of having the call in both branches
you might as well just have one call before the if().  Ohh and this
looks like it could do with a CodingStyle cleanup as well.

kfree(ulFibreFrame);
if (fchs->pl[0] == ELS_LILP_FRAME)
        return 1; /* found the LILP frame! */
/* keep looking */


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/