Re: [patch] fix compilation in collie.c

[Richard Purdie <rpurdie@rpsys.net>]

On Sun, 2005-07-24 at 23:35 +0100, Russell King wrote:
> I'd like John (or someone) to look at this.  I'm particularly worred
> about:
> 
> 1. passing NULL into (read|write)_scoop_reg() - which use dev_get_drvdata()
>    on this.  Given the choice between creating code which will definitely
>    oops but not error or warn vs not compiling, I'll take not compiling
>    any day.

They should read write_scoop_reg(&colliescoop_device.dev, ...); in this
case. 

There is a similar problem with drivers/input/keyboard/corgikbd.c for
which the patch has been in the input maintainer's queue for months :-(.

> 2. whether this is supposed to be using the sharp chip driver rather
>    than the cfi stuff.

I think the aim was to use the cfi code but there were problems with it
not working so the sharp chip driver was being used in the meantime.
John will hopefully be able to comment more about this.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/