Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()

su den 24.07.2005 Klokka 16:36 (+0200) skreiv Rene Scharfe:
> [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
> 
> Function nfs_block_bits() an open-coded version of (the non-existing)
> rounddown_pow_of_two().  That means that for non-power-of-two target
> sizes it returns half the size needed for a block to fully contain
> the target.  I guess this is wrong. :-)  The patch uses the built-in
> roundup_pow_of_two() instead.

What non-power-of-two target? Anything _not_ aligned to a power of two
boundary is a BUG!

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Trond Myklebust <[email protected]>

References:
- [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Rene Scharfe <[email protected]>

Prev by Date: Re: [patch] fix compilation in collie.c
Next by Date: Re: Device supported by the OSS trident driver not supported by ALSA
Previous by thread: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
Next by thread: Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind]