Re: [patch] fix compilation in collie.c

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Thu, Jul 21, 2005 at 07:25:27AM +0200, Pavel Machek wrote:
> This fixes wrong number of arguments in call to write_scoop_reg, fixes
> map_name and John's email. Please apply,
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>

Nacked.

I'd like John (or someone) to look at this.  I'm particularly worred
about:

1. passing NULL into (read|write)_scoop_reg() - which use dev_get_drvdata()
   on this.  Given the choice between creating code which will definitely
   oops but not error or warn vs not compiling, I'll take not compiling
   any day.

2. whether this is supposed to be using the sharp chip driver rather
   than the cfi stuff.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/