Re: [PATCH] Apple USB Touchpad driver (new)

[Vojtech Pavlik <vojtech@suse.cz>]

On Fri, Jul 08, 2005 at 02:10:05PM +0200, Stelian Pop wrote:
> On Fri, Jul 08, 2005 at 01:18:01PM +0200, Johannes Berg wrote:
> 
> > Hi all,
> > 
> > Nice to see this going into the kernel :)
> > 
> > > This is a driver for the USB touchpad which can be found on
> > > post-February 2005 Apple PowerBooks (PowerBook5,6).
> > 
> > This is not perfectly correct, the PowerBook5,6 is afaik only the 15"
> > model, the 12" and 17" have other numbers. Maybe you should just leave
> > that out, likewise in the code/Kconfig file.
> 
> Indeed, corrected.
> 
> > > +/*
> > > + * number of sensors. Note that only 16 of the 26 x sensors are used on
> > > + * 12" and 15" Powerbooks.
> > > + */
> > 
> > I think that is misleading, those sensors don't even exist on 12" and
> > 15" powerbooks. Maybe it should say 'Note that only 16 instead of 26
> > sensors exist on 12" and 15" models'
> 
> Sure, I clarified a bit that sentence.
> 
> Updated patch follows.

Looks good. If you remove the open counter (the open
callback is called only once for each device), and the

> +module_init (atp_init);
> +module_exit (atp_exit);
 
spaces here, I think I can merge it.

Btw, what I don't completely understand is why you need linear
regression, when you're not trying to detect motion or something like
that. Basic floating average, or even simpler filtering like the input
core uses for fuzz could work well enough I believe.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/