Re: [PATCH] Apple USB Touchpad driver (new)

[Johannes Berg <johannes@sipsolutions.net>]

Hi all,

Nice to see this going into the kernel :)

> This is a driver for the USB touchpad which can be found on
> post-February 2005 Apple PowerBooks (PowerBook5,6).

This is not perfectly correct, the PowerBook5,6 is afaik only the 15"
model, the 12" and 17" have other numbers. Maybe you should just leave
that out, likewise in the code/Kconfig file.
> +/*
> + * number of sensors. Note that only 16 of the 26 x sensors are used on
> + * 12" and 15" Powerbooks.
> + */

I think that is misleading, those sensors don't even exist on 12" and
15" powerbooks. Maybe it should say 'Note that only 16 instead of 26
sensors exist on 12" and 15" models'

johannes

Attachment: signature.asc
Description: This is a digitally signed message part