Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()

[Stephen Smalley <sds@epoch.ncsc.mil>]

On Fri, 2005-06-17 at 18:18 +0200, Gerald Schaefer wrote:
> On Fri, 2005-06-17 at 11:57 -0400, Stephen Smalley wrote:
> > 
> > Shouldn't that be nosec_save?  nosec is advanced by take_option().
> > 
> That's right, I muddled that up. Hope I got this one-line patch right
> this time...
> 
> diff -pruN linux-2.6-git/security/selinux/hooks.c linux-2.6-git_xxx/security/selinux/hooks.c
> --- linux-2.6-git/security/selinux/hooks.c	2005-06-16 20:01:03.000000000 +0200
> +++ linux-2.6-git_xxx/security/selinux/hooks.c	2005-06-17 14:38:08.000000000 +0200
> @@ -1945,6 +1945,7 @@ static int selinux_sb_copy_data(struct f
>  	} while (*in_end++);
>  
>  	copy_page(in_save, nosec_save);
> +	free_page((unsigned long)nosec_save);
>  out:
>  	return rc;
>  }

Thanks, looks fine.

Acked-by:  Stephen Smalley <sds@epoch.ncsc.mil>

-- 
Stephen Smalley
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/