Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()

On Fri, 2005-06-17 at 11:57 -0400, Stephen Smalley wrote:
> 
> Shouldn't that be nosec_save?  nosec is advanced by take_option().
> 
That's right, I muddled that up. Hope I got this one-line patch right
this time...

diff -pruN linux-2.6-git/security/selinux/hooks.c linux-2.6-git_xxx/security/selinux/hooks.c
--- linux-2.6-git/security/selinux/hooks.c	2005-06-16 20:01:03.000000000 +0200
+++ linux-2.6-git_xxx/security/selinux/hooks.c	2005-06-17 14:38:08.000000000 +0200
@@ -1945,6 +1945,7 @@ static int selinux_sb_copy_data(struct f
 	} while (*in_end++);
 
 	copy_page(in_save, nosec_save);
+	free_page((unsigned long)nosec_save);
 out:
 	return rc;
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()
    • From: Stephen Smalley <[email protected]>

• References:
  • [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()
    • From: Gerald Schaefer <[email protected]>
  • Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()
    • From: Gerald Schaefer <[email protected]>
  • Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()
    • From: Stephen Smalley <[email protected]>

• Prev by Date: Re: [patch] inotify, improved.
• Next by Date: Re: Oops calling sysfs_create_link() from pci_probe()
• Previous by thread: Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()
• Next by thread: Re: [PATCH 1/1] SELinux: memory leak in selinux_sb_copy_data()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]