On Thu, 16 Jun 2005, Andrew Morton wrote:
> Chris Friesen <[email protected]> wrote:
> > Andrew Morton wrote:
> > > Chris Friesen <[email protected]> wrote:
> > >>Currently tmpfs reuses the simple_dir_operations from libfs.c.
> > >>
> > >>Would it make sense to add the empty fsync() function there, and have
> > >>all other users pick it up as well? Is this likely to break stuff?
> > >
> > > Isn't simple_sync_file() suitable?
Yes.
> > Alternately, if it makes sense for all the users of
> > simple_dir_operations we could modify it directly and all of the other
> > users of simple_dir_operations would get the change for free. I don't
> > know enough about the other filesystems to know if this makes sense or not.
That makes the best sense, yes.
> hm, what a lot of filesystems.
> .....
> I can't think of any reason why any of these would want fsync(dir_fd) to
> return -EINVAL.
No need to check the list: any filesystem using simple_dir_operations
is using dcache_readdir, which implies there's no storage to be synced.
And we all agree that success is a more helpful retval than -EINVAL
when there's nothing for fsync to do. Here's a patch if you haven't
done it already....
tmpfs, and all other users of simple_dir_operations, should return 0
to say directory fsync was successful, instead of the worrying -EINVAL.
Signed-off-by: Hugh Dickins <[email protected]>
--- 2.6.12-rc6-git8/fs/libfs.c 2005-03-02 07:38:44.000000000 +0000
+++ linux/fs/libfs.c 2005-06-17 14:16:29.000000000 +0100
@@ -183,6 +183,7 @@ struct file_operations simple_dir_operat
.llseek = dcache_dir_lseek,
.read = generic_read_dir,
.readdir = dcache_readdir,
+ .fsync = simple_sync_file,
};
struct inode_operations simple_dir_inode_operations = {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
