Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2007-02-22 at 08:46 +0100, Ingo Molnar wrote:
> * Thomas Gleixner <[email protected]> wrote:
> 
> > The problem is that the p->last_ran value is not updated after a 
> > context switch. So a subsequent call to current_sched_time() 
> > calculates with a stale p->last_ran value, i.e. accounts the full 
> > time, which the task was scheduled away.
> > 
> > Signed-off-by: Thomas Gleixner <[email protected]>
> 
> >  	sched_info_switch(prev, next);
> >  	if (likely(prev != next)) {
> > -		next->timestamp = now;
> > +		next->timestamp = next->last_ran = now;
> 
> ouch! nice catch. Also for v2.6.20.2 i think. 2.6.19 should be 
> unaffected.

Yes, was introduced in 2.6.20 and definitely should hit the stable tree.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux