Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value

* Thomas Gleixner <[email protected]> wrote:

> The problem is that the p->last_ran value is not updated after a 
> context switch. So a subsequent call to current_sched_time() 
> calculates with a stale p->last_ran value, i.e. accounts the full 
> time, which the task was scheduled away.
> 
> Signed-off-by: Thomas Gleixner <[email protected]>

>  	sched_info_switch(prev, next);
>  	if (likely(prev != next)) {
> -		next->timestamp = now;
> +		next->timestamp = next->last_ran = now;

ouch! nice catch. Also for v2.6.20.2 i think. 2.6.19 should be 
unaffected.

Acked-by: Ingo Molnar <[email protected]>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
    • From: Thomas Gleixner <[email protected]>

• References:
  • [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
    • From: Thomas Gleixner <[email protected]>

• Prev by Date: Re: [PATCH] update ctime and mtime for mmaped write
• Next by Date: Re: dirty balancing deadlock
• Previous by thread: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
• Next by thread: Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]